Re: [PATCH 2/2] remote-curl: let users turn off smart http
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 20, 2012, 17:53 UTC
- Message-ID
- <7va9wkbmyc.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120920170517.GB18981@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> I added the config item as remote.foo.smarthttp. You could also allow > "http.$url.smart" (and just "http.smart", for that matter), which could > be more flexible if you have multiple remotes pointing to the same > broken server.
What would the user experience be when we introduce "even smarter" http server protocol extension? Will we add remote.foo.starterhttp?
Perhaps
remote.$name.httpvariants = [smart] [dumb]
to allow users to say "smart only", "dumb only", or "smart and/or dumb" might be more code but less burden on the users.
The code obviously looks correct, and the documentation reads fine.