Re: [PATCH] diff.c: diff.renamelimit => diff.renameLimit in message

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2013, 20:43 UTC
Message-ID: <7va9pwa3h9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAM998vHDay2o55Q3v4tfh=tvcmpOHHCPX-Ya5KxVxsn3=jzs3A@mail.gmail.com>

Max Nanasy <max.nanasy@gmail.com> writes:

Show 7 quoted lines

> In the warning message printed when rename or unmodified copy
> detection was skipped due to too many files, change "diff.renamelimit"
> to "diff.renameLimit", in order to make it consistent with git
> documentation, which consistently uses "diff.renameLimit".
>
> Signed-off-by: Max Nanasy <max.nanasy@gmail.com>
> ---

I "git grep"ed around and it tells me that this is the only such place. Thanks.

The patch is severely whitespace damaged. If you plan to keep contributing to Git, I'd like to make sure that your mail toolchain is sane, so that we do not have to keep hand-adjusting patches submitted by you before applying.

Show 18 quoted lines

>  diff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/diff.c b/diff.c
> index 156fec4..052974e 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -4662,7 +4662,7 @@ int diff_result_code(struct diff_options *opt, int status)
>  {
>   int result = 0;
>
> - diff_warn_rename_limit("diff.renamelimit",
> + diff_warn_rename_limit("diff.renameLimit",
>         opt->needed_rename_limit,
>         opt->degraded_cc_to_c);
>   if (!DIFF_OPT_TST(opt, EXIT_WITH_STATUS) &&
> --
> 1.8.1.3