Re: [PATCH] Add support for parallel HTTP transfers
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 7, 2005, 17:01 UTC
- Message-ID
- <7v8xx55kia.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0510071149550.23242@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 10 quoted lines
>> > It should be fine to download objects and a pack that contains them at the >> > same time, although there's currently a check in fetch.c which should be >> > removed, so that it will call fetch() for an object if the object appears >> > between the prefetch() and the fetch(). >> >> Can you provide a patch, or point me toward the right place to make that >> change? > > It's line 168 of fetch.c; the "!has_sha1_file(obj->sha1)" part should go > away.
The check was added in 029f6de377c7e0484f5c4cf070934599580f1784 because back then calling fetch() on an object that we already had had a funny interaction with what http-fetch.c did. I suspect that Nick's curl-multi changes made it unnecessary, but you should double check for other transports.