Re: [PATCH] RFC: proxy-command support for git://

From: Junio C Hamano <junkio@cox.net>
Date: Nov 3, 2005, 18:54 UTC
Message-ID: <7v8xw5h898.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87fyqdbuab.fsf@briny.internal.ondioline.org>

Paul Collins <paul@briny.ondioline.org> writes:

> I spend some of my time using a network that only allows outgoing TCP
> connections to certain ports, and the git-daemon port is not one of them.
> This patch below implements an analogue to ssh's ProxyCommand feature
> for git, as a less messy alternative to ssh port forwarding.

Wonderful.

> Questions:
>
> * Can git already do this and I just failed to notice?

Maybe I just failed to notice this too, but I do not think so.

> * Where should git_use_proxy() look?  Some git configuration file?
>   An environment variable?  Both?  Somewhere else?

My preference is put something in .git/config to describe which proxy command (maybe the same one with different argument) to use depending on where you are going. When you have internal hosts and external hosts you would want this to apply only to external hosts. Maybe you have two or more gateways and depending on which external host you are going you may want to use different proxied connection. On top of the config file, making it overridable from an environment variable would be sensible.