Re: [PATCH] git-cvsimport: Add -A <author-conv-file> option

From: Junio C Hamano <junkio@cox.net>
Date: Jan 13, 2006, 08:45 UTC
Message-ID: <7v8xtkbjnk.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vzmm0g45a.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 10 quoted lines

> Andreas Ericsson <ae@op5.se> writes:
>
>> Anyways, I can keep this separate if you don't want to accept it.
>
> Oh, I haven't formed an opinion on accept/reject yet.  I was
> just trying to see if you are aware of that (especially Pasky's
> message in that thread) and thought about issues like "if in
> some repositories CVSROOT/users is in usable form then perhaps
> making sure -A file has the same format and suggest its use in
> the documentation would be nicer".

OK, after a little googling around, I have formed an opinion. I agree to the patch in principle, but at least it would be nicer to use "CVSROOT/users" compatible format before giving it to the general public.

	http://computing.ee.ethz.ch/sepp/cvs-1.10-to/cvsbook/main_70.html

seems to indicate that:

 - colon ':' is used instead of your '='.

 - RHS, if it contains a whitespace, is quoted either with
   single or double quote.

It was a bit unclear to me how quote characters are to be quoted, so the patch needs a bit of research, quoting (when writing out new records) and unquoting (when reading) in the script, but otherwise I think it is a welcome change.

Opinions from other heavy CVS users?