Re: [PATCH] shared repository settings enhancement.

From: Junio C Hamano <junkio@cox.net>
Date: Jun 10, 2006, 03:49 UTC
Message-ID: <7v8xo5lleo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0606091743410.5498@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 17 quoted lines

> On Fri, 9 Jun 2006, Junio C Hamano wrote:
>>
>> This lets you say:
>> 
>> 	[core]
>> 		sharedrepository = 075
>
> I really think it's better to express this as some more traditional 
> number.
>
> I had to think about what 075 meant, while saying
>
> 	[core]
> 		sharedrepository = 0644
>
> just makes sense more or less automatically (and yes, for directories, the 
> read bit should obviously be expanded as an execute bit).

Or probably use the umask notation, 007 for traditional shared repositories and 002 for gitweb exported ones. With your notation, people would start wondering what the distinction between 0755, 0644, and even 0254 is (there isn't any).

Having said that, I do not think the distinction is that important; I would rather make the core.sharedrepository = true to mean an equivalent of "chmod go+rX" (it does "chmod g+rX" currently).