Re: [PATCH] autoconf: Add checking for BSD-compatibile 'install' program

From: Junio C Hamano <junkio@cox.net>
Date: Sep 7, 2006, 20:21 UTC
Message-ID: <7v8xkvxwa7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200609071431.18343.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 11 quoted lines

> Uncomment `AC_PROG_INSTALL' macro in configure.ac, and setting
> `INSTALL' variable in config.mak.in
>
> Add `install-sh' shell script (required when using `AC_PROG_INSTALL'
> macro) scriptversion=2005-11-07.23, taken from KDE SDK 3.5.3.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Perhaps `install-sh' script should be replaced by something simplier,
> for example by script which was sent to git mailing list, but AFAIK
> not accepted.

That somehow sounds like whining. I do not think it was never proposed for inclusion but was just offered as a friendly "somebody else might find it useful".

In any case, I have two issues, but one non-issue first. I am not opposed to including install-sh that is maintained somewhere upstream and GPLv2 compatible.

 - I do not particularly like to have too many autoconf related
   cruft at the toplevel, and I am wondering if we can move it
   to say compat/install-sh.

 - I suspect this fall-back would set "INSTALL = ./install-sh"
   (if you have it in compat, "INSTALL = compat/install-sh").  I
   wonder if it breaks builds in subdirectories
   (i.e. Documentation/ and templates/).