git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb fix validating pg (page) parameter

From
Junio C Hamano <junkio@cox.net>
Date
Sep 17, 2006, 21:45 UTC
Message-ID
<7v8xki2mmb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20060917213838.GA12782@moooo.ath.cx>
Matthias Lederhofer <matled@gmx.net> writes:
Show 5 quoted lines
>> > +	if ($page =~ m/[^0-9]/) {
>...
> The first page seems to have number 0.  After removing the 1 <= $page
> this code should do the same as my patch, apply whatever you think is
> easier to read (I prefer if over unless most of the time).

Ah, I did not notice we call the first page 0; barfing on any non-digit in the string like you do sounds quite sane.

Thanks.
Previous: Matthias Lederhofer
Message 4 of 4 in “gitweb fix validating pg (page) parameter”
  1. gitweb fix validating pg (page) parameterMatthias Lederhofer, Sep 17, 2006
  2. Junio C HamanoSep 17, 2006
  3. Matthias LederhoferSep 17, 2006
  4. Junio C HamanoSep 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.