Re: [PATCH] Fix cg-commit -p to not touch the working tree
- From
Junio C Hamano <junkio@cox.net>
- Date
- Feb 12, 2007, 04:25 UTC
- Message-ID
- <7v8xf4atoe.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070212031923.D20B913A382@magnus.utsl.gen.nz>
Sam Vilain <sam.vilain@catalyst.net.nz> writes:
> Previously, the working tree state was modified with `patch', which > was a fragile operation. Do everything with `git-apply --cached > --index' instead.
I do not use Cogito so I do not know what behaviour is wanted here, but '--cached --index' is same as saying just '--cached' as far as I know. It will patch against the index and should not touch working tree. If the original used 'patch' to apply, I suspect it wanted to touch the working tree (and possibly, it wanted to leave the index alone?), so --cached might be completely wrong thing to use here?