Re: git-send-email vs address syntax

From: Junio C Hamano <junkio@cox.net>
Date: May 3, 2007, 06:25 UTC
Message-ID: <7v8xc62zky.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <CFF307C98FEABE47A452B27C06B85BB6030BDEAF@hdsmsx411.amr.corp.intel.com>

"Brown, Len" <len.brown@intel.com> writes:

> I don't know if the fix should be in the git-am script
> which set the From: field, or in the git-format-patch
> script which takes that field and makes it into
> an e-mail message.

The fix should be in send-email script, as COMMITTER_NAME and AUTHOR_NAME are just simple strings without RFC2822 limitation (such as necessity of quoting a ".").

As a matter of fact, recent enough send-email is supposed to have a fix for this exact problem. If your copy of send-email does not have

	sub sanitize_address_rfc822 {

you might want to upgrade. Both 1.5.2-rc1 and 1.5.1.3 have this.