Re: A question about git-rev-list

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2007, 04:33 UTC
Message-ID: <7v8x9fbqdu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <85bqecm4mn.fsf@lola.goethe.zz>

David Kastrup <dak@gnu.org> writes:

Show 23 quoted lines

> ...  The problem I have
> with that is that "somefile.c" renders commits uninteresting, but
> not if they have interesting parents (what do their parents have to do
> with it?).  So if I have
>
> A -> B -> B1 -> C -> HEAD
>
> where somefile.c does not change between B and B1, then
> git-rev-list HEAD --not B -- somefile.c
> spews out
> HEAD
> C
> and that's it.  Quite as expected.  However, 
> git-rev-list HEAD --not B --parents -- somefile.c
> spews out
> HEAD C
> C B1
> B1 B
>
> and look and behold, B1 became interesting because of its unlisted
> parent B.
>
> There is something wrong with that.

There indeed is, and that is not what I am seeing.

Running this script in an empty directory gives me:

    #!/bin/sh

    GIT_AUTHOR_NAME='A U Thor'
    GIT_AUTHOR_EMAIL=a.u.thor@example.xz
    GIT_COMMITTER_NAME="$GIT_AUTHOR_NAME"
    GIT_COMMITTER_EMAIL="$GIT_AUTHOR_EMAIL"
    GIT_AUTHOR_DATE='2007-07-16 00:00:00 +0000'
    GIT_COMMITTER_DATE='2007-07-16 00:00:00 +0000'

    export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL \
            GIT_AUTHOR_DATE GIT_COMMITTER_DATE

    rm -fr .git
    git init
    echo A >somefile.c; git add somefile.c; git commit -m 'A'; git tag A
    echo B >somefile.c; git add somefile.c; git commit -m 'B'; git tag B
    echo B1 >another; git add another; git commit -m 'B1'; git tag B1
    echo C >somefile.c; git add somefile.c; git commit -m 'C'; git tag C
    echo H >somefile.c; git add somefile.c; git commit -m 'H'; git tag H

    git rev-list --parents HEAD --not B -- somefile.c |
    git name-rev --tags --stdin

$ sh t000.sh
Initialized empty Git repository in .git/
Created initial commit 7a13cf5: A
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 somefile.c
Created commit b66d40b: B
 1 files changed, 1 insertions(+), 1 deletions(-)
Created commit 5530c91: B1
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 another
Created commit 7ee2b7e: C
 1 files changed, 1 insertions(+), 1 deletions(-)
Created commit 71fafc0: H
 1 files changed, 1 insertions(+), 1 deletions(-)
71fafc0f49ffb82b123c09ec0857f9f458ed32c4 (tags/H) 7ee2b7ed072190c56a2eedda3130f6bb729d0da1 (tags/C)
7ee2b7ed072190c56a2eedda3130f6bb729d0da1 (tags/C) b66d40bd7ed6d7403c16d8e37e6e410852598247 (tags/B)

The commit listed are H and then C; their (rewritten) parents are C and B, respectively.