Re: [PATCH] Force new line at end of commit message
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 30, 2007, 12:21 UTC
- Message-ID
- <7v8x3c8jay.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <200712301158.lBUBwT3r004608@mi1.bluebottle.com>
しらいしななこ <nanako3@bluebottle.com> writes:
Show 6 quoted lines
>> Heh, I can see that you do not care---the original did not even >> add a newline when necessary (and that is why we have this >> thread). Instead you were adding a newline regardless to the >> end of the first commit, but not doing so for the other ones. > > Aren't you being too harsh on Johannes these days?
Not on purpose, but perhaps I might have been.
> Everybody knows that you are capable of rewriting that part in Perl or Python yourself to fix the issue.
I actually have been trying to avoid Perl (let alone Python nor Ruby) as "rebase -i" is primarily Johannes's bailiwick, and I had an impression that he avoided them for Windows portability.
Unfortunately, sed does not handle incomplete lines well, at least portably. POSIX says very little about it, except that its input shall be "text files" (i.e. no NUL is allowed, each line separated with <newline> and with less than {LINE_MAX} bytes in length), and its default operation shall read each line less its terminating <newline> and after manipulation spit it out and immediately follow it with a <newline>. But a popular implementation (e.g. GNU) actually does not follow the output with a <newline> if the input was incomplete line [*1*]
[Footnote]
*1* Otherwise, this would have been a way to add a missing newline to a file that could end with an incomplete line:
$ sed -e '' <$file_that_may_end_with_an_incomplete_line