git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Fix git pull handling of the quiet option

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2008, 04:04 UTC
Message-ID
<7v8x0ssfud.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1205020356-6682-3-git-send-email-iusty@k1024.org>
Iustin Pop <iusty@k1024.org> writes:
> Although git pull has a documented quiet option,...

I think that is a documentation bug. pull accepts all options for fetch for the sole purpose of passing them intact to underlying fetch, and some options to fetch does not even make much sense in the context of pull.

Also options to pull needs to come first; the options pull does not know about is a signal for pull that the rest is for consumption of underlying fetch.

If you want to teach --quiet to pull, however, your patch is the right approach. pull would eat --quiet and make a note for itself, and passes that to underlying fetch (and perhaps merge).

You also need to sign-off your patch and add tests to make sure that other people will not break your enhancement in the future.

Previous: Iustin PopNext: Iustin Pop
Message 5 of 7 in “Improve git pull --quiet behaviour”
  1. Iustin PopMar 8, 2008
  2. 1/2 Add a quiet option to git mergeIustin Pop, Mar 8, 2008
  3. Add a quiet option to git mergeIustin Pop, Mar 9, 2008
  4. 2/2 Fix git pull handling of the quiet optionIustin Pop, Mar 8, 2008
  5. Junio C HamanoMar 9, 2008
  6. Iustin PopMar 9, 2008
  7. Fix git pull handling of the quiet optionIustin Pop, Mar 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.