git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: diff --check is stupid about blank lines

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2008, 22:39 UTC
Message-ID
<7v8wurnwf6.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080820222048.GB8137@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> On Wed, Aug 20, 2008 at 11:42:34AM -0700, Junio C Hamano wrote:
>
>> Ahhh, what idiot wrote the logic for checking trailing blank lines in
>> checkdiff_consume().
>> 
>> It does not ask for any context lines.  Sheesh.
>> 
>> This should fix it.
>
> Ah, that was much easier than I expected. ;)
>
> Maybe this should be squashed in?
Thanks but I've done that myself already.
Previous: Jeff King
Message 7 of 7 in “diff --check is stupid about blank lines”
  1. Björn SteinbrinkAug 20, 2008
  2. Jeff KingAug 20, 2008
  3. Junio C HamanoAug 20, 2008
  4. Junio C HamanoAug 20, 2008
  5. Björn SteinbrinkAug 20, 2008
  6. Jeff KingAug 20, 2008
  7. Junio C HamanoAug 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.