Re: [PATCH/RFC] Documentation/SubmittingPatches: emacs whitespace tip
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 13, 2009, 08:28 UTC
- Message-ID
- <7v8wpfd2yw.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <87k58zopg5.fsf@jidanni.org>
jidanni@jidanni.org writes:
Show 15 quoted lines
> Signed-off-by: jidanni <jidanni@jidanni.org> > --- > Documentation/SubmittingPatches | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index ba07c8c..7b64343 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -442,6 +442,8 @@ whitespaces (fatal in patches). Running 'C-u g' to display the > message in raw form before using '|' to run the pipe can work > this problem around. > > +Inside gnus or not, a (setq-default show-trailing-whitespace t) in > +one's ~/.emacs file will reduce whitespace embarrassment incidents.
What bothered me a lot more is that this part (and only this part) talks about patch acceptance tip, not patch submission tip. The Gnus/Emacs section needs a total rewrite, I think.
Having a separate patch acceptance tip is fine, but I do not think it belongs to SubmittingPatches document, and the current text certainly does not mesh well with its neighbours.