Re: [PATCH] git-bundle doc: update examples

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2009, 22:44 UTC
Message-ID: <7v8woln7ol.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090204181529.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 16 quoted lines

> This rewrites the example part of the bundle doucmentation to follow
> the suggestion made by Junio during a recent discussion (gmane 108030).
> 
> Instead of just showing different ways to create and use bundles in a
> disconnected fashion, the rewritten example first shows the simplest
> "full cycle" of sneakernet workflow, and then introduces various
> variations.
> 
> The words are mostly taken from Junio's outline. I only reformatted
> them and proofread to make sure the end result flows naturally.
> 
> Signed-off-by: Nanako Shiraishi <nanako3@lavabit.com>
> ---
> I didn't want your improvement suggestion to go to waste either, so
> here is a proposed conclusion of this topic in a patch form, hopefully
> in a good enough quality.

I appreciate your help like this patch, and your other contributions of "project secretary" kind, pointing out old threads, prodding about unapplied patches, etc., because I do not have infinite amount of time.

The text seems to follow my "this might flow more naturally and easier to read" outline exactly, and I do not have a problem with the patch itself. Among the people who were involved in the review, Jidanni seemed to be of the same opinion, but I haven't heard from Dscho one way or another. So I'd keep this on hold for now but I think the examples are organized much better with this version and we should take it.

HOWEVER.

Show 6 quoted lines

> After the maintainer spent a lot of time to suggest how to improve a
> proposed patch for inclusion, it is rude for a contributor to walk
> away without following through the review process. Such a proposed
> patch is not contributing to the development process but only stealing
> maintainer's and reviewers' time from the community. But others like I
> can at least try to help (^_^;).

I see a smiley, but what's with the animosity? One thing I've always liked about your messages to this list is that they have an exceptional signal to noise ratio, certainly much better than mine [*1*].

I saw you were annoyed by his recent "bug tracker" remark in another thread, and I do appreciate that you are showing a better way to help by setting an example, but I think this comment is counterproductive.

[Footnote]

*1* You certainly never said anything like giving furniture to somebody else ;-)