Re: [PATCH v2] Re: add documentation for mailinfo.scissors and '--no-scissors'

Nicolas Sebrecht <nicolas.s.dev@gmx.fr> writes:

You _could_ argue that we _could_ describe a long option "frotz" that lacks the '!' flag in OPTIONS_SPEC as "--[no-]frotz" in the output by changing the rev-parse --parseopt, if you really want to.

However, I think that is not done deliberately to avoid cluttering the output. I Cc'ed the primary guilty party ;-) of the parse-options infrastructure.

Currently, non-bool options are not marked with '!'. Nobody sane would say "git am --no-directory foo", but "rev-parse --parseopt" acccepts such a nonsense input, and it is up to the calling script to catch it and barf. But "rev-parse --parseopt" will start saying "--[no-]directory=" with such a change, which is not good.

And --no-scissors is not that special. We could add --no-signoff to say "I do not want to sign-off this one time" explicitly, and it is crazy if we had to add another line in OPTIONS_SPEC when we want to do so, when it is clear "signoff" option is a boolean.

As a long term direction, I'd rather not to see "no-" in OPTIONS_SPEC, but have that taken care of by "rev-parse --parseopt" to keep our sanity. The only existing offender is "no-verify" in "rebase -i". Let's solve it (if there is anything to solve, which I doubt) without adding new ones.