git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] reset: unbreak hard resets with GIT_WORK_TREE

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 30, 2009, 17:54 UTC
Message-ID
<7v8wck2vpt.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091230084702.GA19649@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> Commit 952dfc6 tried to tighten the safety valves for doing
> a "reset --hard" in a bare repository or outside the work
> tree, but accidentally broke the case for GIT_WORK_TREE.
> This patch unbreaks it.
>
> Most git commands which need a work tree simply use
> NEED_WORK_TREE in git.c to die before they get to their
> cmd_* function. Reset, however, only needs a work tree in
> some cases, and so must handle the work tree itself. The
> error that 952dfc6 made was to simply forbid certain
> operations if the work tree was not set up; instead, we need
> to do the same thing that NEED_WORK_TREE does, which is to
> call setup_work_tree(). We no longer have to worry about dying
> in the non-worktree case, as setup_work_tree handles that
> for us.
Sounds very sane to me.  Thanks.
Previous: Jeff King
Message 9 of 9 in “Possible bug in 1.6.6 with reset --hard and $GIT_WORK_TREE”
  1. Fyn FynnDec 29, 2009
  2. Tay Ray ChuanDec 29, 2009
  3. Nguyen Thai Ngoc DuyDec 29, 2009
  4. Nanako ShiraishiDec 29, 2009
  5. Nguyen Thai Ngoc DuyDec 29, 2009
  6. Fyn FynnDec 29, 2009
  7. Jeff KingDec 29, 2009
  8. reset: unbreak hard resets with GIT_WORK_TREEJeff King, Dec 30, 2009
  9. Junio C HamanoDec 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.