Re: [PATCH] Documentation/SubmittingPatches: fix Gmail workaround advice

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 7, 2010, 18:37 UTC
Message-ID: <7v8wb4gaef.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1265555642-40204-1-git-send-email-git@aaroncrane.co.uk>

Aaron Crane <git@aaroncrane.co.uk> writes:

Show 8 quoted lines

> The suggested approach to dealing with Gmail's propensity for breaking
> patches doesn't seem to work.  Recommend an alternative technique which
> does.
>
> Signed-off-by: Aaron Crane <git@aaroncrane.co.uk>
> ---
> Thanks to Sverre Rabbelier, Jacob Helwig, David Aguilar, and Jay Soffian for
> their suggestions; the advice here comes from them.

Do you know _why_ it does not work? For example, does it not work _at all_ for you? Or only certain things does not reliably work (iow, perhaps you are seeing a bug in imap-send)? We might want to find who wrote the imap-send recommendation and ask their input.

What I am trying to get at is to see if the current imap-send suggestion is fundamentally unworkable with gmail. Perhaps they stopped supporting imap. Perhaps the procedure never worked. I would be very happy to apply your patch as is if that is the case.

But if the trouble you had is something fixable, I think removal of the original text is unfriendly to people who have only imap reachability to gmail---the description instead needs fixing.