Re: [PATCH] gitweb: Die if there are parsing errors in config file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 14, 2010, 21:17 UTC
- Message-ID
- <7v8wava55y.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20100207093744.29846.6468.stgit@localhost.localdomain>
Jakub Narebski <jnareb@gmail.com> writes:
Show 10 quoted lines
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 1f6978a..a5bc359 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -556,6 +556,8 @@ if (-e $GITWEB_CONFIG) {
> our $GITWEB_CONFIG_SYSTEM = $ENV{'GITWEB_CONFIG_SYSTEM'} || "++GITWEB_CONFIG_SYSTEM++";
> do $GITWEB_CONFIG_SYSTEM if -e $GITWEB_CONFIG_SYSTEM;
> }
> +# die if there are errors parsing config file
> +die $@ if $@;I cannot figure out $@ from which command this if statement modifier is checking when none of GITWEB_CONFIG or GITWEB_CONFIG_SYSTEM candidates is present. Neither of the "do" executes in such a case. Do you end up checking the result from the very first eval that checks if Time::HiRes can be "require"d successfully?