Re: [PATCH] Make git log --follow support --find-copies-harder.

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2010, 16:56 UTC
Message-ID: <7v8w8gbv75.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1271860641-29305-1-git-send-email-struggleyb.nku@gmail.com>

Bo Yang <struggleyb.nku@gmail.com> writes:

> 'git log --follow --find-copies-harder <path>' don't track copies
> from unmodified files, and this patch fix it.

What does the command do when given a single -C instead of --f-c-h, with or without your patch? What should it do?

Because try_to_follow_renames() is supposed to be a rare-event (it only happens when a path we have been following disappears), I am having this feeling that it would make more sense to do this change unconditionally.

Two possible outcomes that this patch allows the users to have by giving them a choice to give (or not to give) --f-c-h are:

 (1) the path is judged to be new in a commit and traversal finishes
     there; or

 (2) the path is found to be a copy from another path from one of the
     parents and traversal continues.

But I think using --follow is a sure sign of the user wanting the latter and never the former, no?