Re: [PATCH 1/2] format-patch: Add a signature option (--signature)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 16, 2010, 20:55 UTC
- Message-ID
- <7v8w6eelyi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <AANLkTikM8fRb7oeeMrsEfqTzDAYhTJxN63mblhyUXJM6@mail.gmail.com>
Stephen Boyd <bebarino@gmail.com> writes:
Show 13 quoted lines
> On Wed, Jun 16, 2010 at 9:53 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Theodore Tso <tytso@MIT.EDU> writes: >> >>> I don't know how important people will feel this to be, but I've occasionally >>> found it interesting to see how many people are using various different >>> versions of git in a particular development community, and having the >>> version in the signature is a useful gauge on that. >> >> The original motivation of the version signature was exactly that ;-). > ... > The real question is how useful is it to have the version number > there? There are other ways to gauge the version usage and it's opt-in > so you'll still get some version number coverage.
I sent the previous message without finishing that sentence. I personally have been feeling that the version number there outlived its usefulness for quite some time.
If others (like Ted) find it useful/amusing/interesting, we may want to keep the default and make sure it is not too easy to customize it away, and I think what your patch does is fine.
Thanks.