git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] merge-recursive: Fix multiple file rename across D/F conflict

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2010, 23:17 UTC
Message-ID
<7v8w438q9k.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1282089199-17253-3-git-send-email-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
> I'm really embarrased about this one...  :-/
Let's embarrass you even more ;-)

After 5a2580d, the merge has become very noisy, and I don't see a good reason for that change.

With a version of git built from 5a2580d^, for example, merging sp/fix-smart-http-deadlock-on-error into maint would give me this:

----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Auto-merging remote-curl.c
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------
With 5a2580d, it has become this:
----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Adding builtin/add.c
Auto-merging remote-curl.c
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------
And with this patch on top, it will make it a disaster:
----------------
$ git merge sp/fix-smart-http-deadlock-on-error
Adding builtin/add.c
... similar 97 Adding lines omitted ...
Adding gitweb/static/gitweb.js
Auto-merging remote-curl.c
Adding t/lib-t6000.sh
Adding t/t7810-grep.sh
Adding t/t9350-fast-export.sh
Merge made by recursive.
 remote-curl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
----------------
Previous: Junio C HamanoNext: Elijah Newren
Message 5 of 6 in “Fix multiple file rename across D/F conflict”
  1. 0/2 Fix multiple file rename across D/F conflictElijah Newren, Aug 17, 2010
  2. 1/2 t6031: Add a testcase covering multiple renames across a D/F conflictElijah Newren, Aug 17, 2010
  3. 2/2 merge-recursive: Fix multiple file rename across D/F conflictElijah Newren, Aug 17, 2010
  4. Junio C HamanoAug 18, 2010
  5. Junio C HamanoAug 18, 2010
  6. Elijah NewrenAug 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.