Re: [PATCH] log which temporary file could not be created
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2010, 03:56 UTC
- Message-ID
- <7v8w24oygk.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20101010180909.GA12320@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 16 quoted lines
> Arnout Engelen wrote: >> On Sat, Oct 09, 2010 at 09:41:24PM -0500, Jonathan Nieder wrote: > >>> fatal: Unable to create temporary file '.merge_file_Sc7R5c': File exists >>> fatal: Unable to create temporary file 'newrepo/.git/tOWHcxk': No space left on device >> >> Perhaps we should also log the current working directory when the temporary >> filename is relative? > > Let's step back for a moment. Was there an example that prompted > this patch? Were you aware of where git would be trying to create > files in that example? (I'm genuinely curious.) > > Converting the filename to an absolute path with make_absolute_path > might be useful, but I am not entirely sure it is worth the > complication.
For that matter, I am not sure if it is worth the strdup "just in case it fails" either.