Re* [PATCH 2/3] t1301-*.sh: Fix the 'forced modes' test on cygwin

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2011, 19:31 UTC
Message-ID: <7v8vswcn9s.fsf_-_@alter.siamese.dyndns.org>
In-Reply-To: <4DFCF6AF.3060502@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> No, that is indeed a bug. See commit 7974843 (compat/cygwin.c: make
> runtime detection of lstat/stat lessor impact, 23-10-2008).

Let's fix it while the bug has our attention, then.

-- >8 --
Subject: cygwin: trust executable bit by default

Earlier 7974843 (compat/cygwin.c: make runtime detection of lstat/stat lessor impact, 2008-10-23) fixed the low-level "do we use cygwin specific hacks for stat/lstat?" logic not to call into git_default_config() from random codepaths that are typically very late in the program, to prevent the call from potentially overwriting other variables that are initialized from the configuration.

However, it forgot that on Cygwin, trust-executable-bit should default to true.

Noticed by J6t, confirmed by Ramsay Jones, and the brown paper bag is on Gitster's head.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 compat/cygwin.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/compat/cygwin.c b/compat/cygwin.c
index b4a51b9..ba3327f 100644
--- a/compat/cygwin.c
+++ b/compat/cygwin.c
@@ -101,7 +101,7 @@ static int cygwin_stat(const char *path, struct stat *buf)
  * and calling git_default_config() from here would break such variables.
  */
 static int native_stat = 1;
-static int core_filemode;
+static int core_filemode = 1; /* matches trust_executable_bit default */
 
 static int git_cygwin_config(const char *var, const char *value, void *cb)
 {