Re: url.<base>.insteadOf with empty value

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 14, 2011, 17:57 UTC
Message-ID: <7v8von1mnd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <54556728-92C0-4992-9831-0D582C383235@jetbrains.com>

Kirill Likhodedov <Kirill.Likhodedov@jetbrains.com> writes:

Show 8 quoted lines

> If I don't specify any value for url.<base>.insteadOf or url.<base>.pushInsteadOf, Git substitutes all urls for remotes defined in .git/config
>
> Probably that's because any url starts with empty string and thus has to be substituted. 
> But it might be a bit confusing, because on the other hand if no value is given to the property insteadOf, user may expect this property to be ignored.
>
> Please check if current Git behavior is correct. 
>
> If it is not a bug, I'd suggest to add a note to man git-config about this.

Please assume that what the documentation says is clear enough for whoever wrote it and need no further clarification, so you would need to help them understand what additional things you may want the documentation to say, by clarifying "add a note" and "about this" a bit.

The "insteadOf" replacement is meant to apply for any URL we use. I would be surprised if it did not affect pushURL; it would be a bug if it didn't.

On the other hand, the rewrite done by "pushinsteadof" is meant to apply only when remote.<any>.url is used for pushing. See t/t5516-fetch-push.sh part of the patch for 1c2eafb (Add url.<base>.pushInsteadOf: URL rewriting for push only, 2009-09-07). It would clarify what the intended interaction among these configuration variables.

Thanks.