Re: [PATCH] add post-fetch hook
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 27, 2011, 06:37 UTC
- Message-ID
- <7v8vly8qqx.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20111226155152.GA29582@gnu.kitenet.net>
Joey Hess <joey@kitenet.net> writes:
> .... And other code in git uses an async feeder similarly, > see for example convert.c's apply_filter(). So I think this is ok..?
Yeah, I didn't look at your patch (sorry) but if it uses async like the filtering codepath does, it should be perfectly fine (please forget about the select(2) based kludge I alluded to; the async interface is the right thing to use here).
Thanks.