git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 3/3] push: add 'prune' option

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 22, 2012, 20:56 UTC
Message-ID
<7v8vjua8p9.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAMP44s3+XCM1E_AtW1yGifmGoGSkFSpSTaFbbMffz+hmUzWahw@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
>> Perhaps "enum map_direction { SRC_TO_DST, DST_TO_SRC }" or something?
>
> I think only FROM_SRC, FROM_DST is more than enough to figure it out.

Yeah, as you can tell from my "or something", as long as the name makes the direction clear, I don't care too much about the exact spelling.

Show 6 quoted lines
>> Perhaps rename this to "map_push_refs()" or something in the patch 2/3?
>
> I think get_ref_match() would be more appropriate because we are
> acting on a specific (singular) ref, and the primary thing we care
> about is getting the peer name, based on the refspec match, which we
> might want as a return value.

Again, as long as the name makes it clear this is meant only for "push" and never be used for "fetch", I am fine with it. One way to make it sure is to have a substring "_push" somewhere in that name.

> Probably some rebase mistake =/
Thanks; I was wondering if there is something subtle unexplained going on.
Previous: Felipe ContrerasNext: Felipe Contreras
Message 12 of 17 in “push: add 'prune' option”
  1. 0/3 push: add 'prune' optionFelipe Contreras, Feb 17, 2012
  2. 1/3 remote: use a local variable in match_push_refs()Felipe Contreras, Feb 17, 2012
  3. Junio C HamanoFeb 17, 2012
  4. 2/3 remote: reorganize check_pattern_match()Felipe Contreras, Feb 17, 2012
  5. Junio C HamanoFeb 17, 2012
  6. Felipe ContrerasFeb 22, 2012
  7. Junio C HamanoFeb 22, 2012
  8. 3/3 push: add 'prune' optionFelipe Contreras, Feb 17, 2012
  9. Jeff KingFeb 17, 2012
  10. Junio C HamanoFeb 17, 2012
  11. Felipe ContrerasFeb 22, 2012
  12. Junio C HamanoFeb 22, 2012
  13. Felipe ContrerasFeb 22, 2012
  14. Junio C HamanoFeb 22, 2012
  15. Nguyen Thai Ngoc DuyFeb 21, 2012
  16. Jeff KingFeb 21, 2012
  17. Nguyen Thai Ngoc DuyFeb 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.