Re: [PATCH 0/4] grep: add more information to hunk separators
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 26, 2012, 21:19 UTC
- Message-ID
- <7v8vinnjqy.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F70DBAC.4010609@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> What we also could do: Produce a valid unified diff that would remove > the matching lines if we were to apply it (or the --reverse, i.e. + > instead of -). Then we wouldn't need to invent a special format, but > the output would be a bit more verbose due to the added +++ lines.
Hrm, certainly that is an option that saves a lot of thinking.
As people tend to learn to focus more on '+' lines when reading patches in the unified context format, the reverse option would produce output that is easier to read, I would guess.
> I guess it's time to implement these options in order to try them out > against real code. Won't have time to do so before the second half of > the week, however.
That's OK---we are in no hurry. Have you heard about pre-release feature freeze already ;-)?