Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2012, 17:18 UTC
Message-ID: <7v8vd6alqe.fsf@alter.siamese.dyndns.org>
In-Reply-To: <002201cd807d$0e83d300$2b8b7900$@schmitz-digital.de>

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>

At the very least, please mention that this reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of libcURL.

Show 27 quoted lines

> ---
>  http.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/http.c b/http.c
> index b61ac85..18bc6bf 100644
> --- a/http.c
> +++ b/http.c
> @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result,
> int target, int options)
>                                 ret = HTTP_REAUTH;
>                         }
>                 } else {
> +#if LIBCURL_VERSION_NUM >= 0x070c00
>                         if (!curl_errorstr[0])
>                                 strlcpy(curl_errorstr,
>  
> curl_easy_strerror(results.curl_result),
>                                         sizeof(curl_errorstr));
> +#endif
>                         ret = HTTP_ERROR;
>                 }
>         } else {
> --
> 1.7.12
>
> Bye, Jojo