git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] config: add support for http.<url>.* settings

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 15, 2013, 04:02 UTC
Message-ID
<7v8v18fp2s.fsf@alter.siamese.dyndns.org>
In-Reply-To
<47B58075-3FDD-48E5-9047-8650F7FC5E3B@gmail.com>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 10 quoted lines
> On Jul 12, 2013, at 13:58, Aaron Schrab wrote:
> ...
> This should guarantee a match in the scenario Aaron proposes above and
> still has pretty much the same easy explanation to the user.
>
> Shall I go ahead and add that to the next patch version?
>
> Or proceed with what's there right now (there are a few pending
> updates from reviewers) and then, as Junio says above, adjust it later
> if needed?

I have been assuming that "strictly textual match" will be a subset of the matching semantics Aaron and Peff suggested. That is, if we include your version in the upcoming release, the user writes the http.<URLpattern>.<variable> configuration so that the entries match what they want them to match, the enhanced URL matcher Aaron and Peff suggested will still make them match.

Am I mistaken? Will there be some <URLpattern> that will not match with the same URL literally?

Assuming that Aaron and Peff's enhancement will not be a backward incompatible update, my preference is to take the posted matching semantics as-is (you may have some other changes that does not change the "strictly textual match" semantics).

I do not have strong opinion but Aaron and Peff seem to know what they are talking about, so they will be a better guide to work with you and polish such enhancement on top of what you have now, as a separate change that may need more time to mature.

Previous: Kyle J. McKayNext: Jeff King
Message 8 of 11 in “config: add support for http.<url>.* settings”
  1. config: add support for http.<url>.* settingsKyle J. McKay, Jul 11, 2013
  2. Junio C HamanoJul 11, 2013
  3. Jeff KingJul 12, 2013
  4. Kyle J. McKayJul 12, 2013
  5. Aaron SchrabJul 12, 2013
  6. Jeff KingJul 15, 2013
  7. Kyle J. McKayJul 13, 2013
  8. Junio C HamanoJul 15, 2013
  9. Jeff KingJul 15, 2013
  10. Kyle J. McKayJul 15, 2013
  11. Jeff KingJul 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.