git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Make .git directory validation code test HEAD

From
Junio C Hamano <junkio@cox.net>
Date
Aug 28, 2005, 04:56 UTC
Message-ID
<7v7je6slps.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0508271334320.3317@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> This also removes the tests for "$GIT_DIR" and "$GIT_OBJECT_DIRECTORY" 
> being directories, since the other tests will implicitly test for that 
> anyway (ie the tests for HEAD, refs and 00 would fail).

I've thought about it when you brought up the Andrew's naked git repository detection issue, but one thing I was undecided was that if we would want to forbid either of these "directories" being a symlink to another directory. I think it would be OK; admittedly "test -d" says OK for a symlink to a directory.

I accept the patch, but will not apply and push it out right now; I am not in a shape to be operating heavy equipment ;-). Please wait until tomorrow morning.

Previous: Linus Torvalds
Message 5 of 5 in “cvsimport error: need a valid pathname”
  1. Kalle ValoAug 27, 2005
  2. Martin LanghoffAug 27, 2005
  3. Kalle ValoAug 27, 2005
  4. Make .git directory validation code test HEADLinus Torvalds, Aug 27, 2005
  5. Junio C HamanoAug 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.