[PATCH/RFH] Racy GIT (part #3)

From: Junio C Hamano <junkio@cox.net>
Date: Jun 29, 2006, 21:50 UTC
Message-ID: <7v7j2zpr6k.fsf@assigned-by-dhcp.cox.net>

Does everybody have "cp -p" to preserve the file timestamps on his/her platform? I am assuming this is safe (it is in POSIX), but please raise hand if that is not a case for you.

-- >8 -- Commit 29e4d3635709778bcc808dbad0477efad82f8d7e fixed the underlying update-index races but git-commit was not careful enough to preserve the index file timestamp when copying the index file. This caused t3402 test to occasionally fail.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 git-commit.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-commit.sh b/git-commit.sh
index 7e50cf3..22c4ce8 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -29,7 +29,7 @@ THIS_INDEX="$GIT_DIR/index"
 NEXT_INDEX="$GIT_DIR/next-index$$"
 rm -f "$NEXT_INDEX"
 save_index () {
-	cp "$THIS_INDEX" "$NEXT_INDEX"
+	cp -p "$THIS_INDEX" "$NEXT_INDEX"
 }
 
 report () {

-- 
1.4.1.rc2.g3257-dirty