Re: [PATCH] Avoid accessing a slow working copy during diffcore operations.

From: Junio C Hamano <junkio@cox.net>
Date: Dec 16, 2006, 13:38 UTC
Message-ID: <7v7iwsezaq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0612161253080.3635@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

> On Fri, 15 Dec 2006, Junio C Hamano wrote:
>
>> Also I'd prefer doing this without #ifdef;
>> 
>>         if (defined(NO_FAST_WORKING_DIRECTORY) &&
>>         	!want_file && has_sha1_pack(sha1, NULL))
>> 		return 0;
>
> Are you sure? AFAIU it is an OS dependent problem, so it should not be 
> configurable at runtime anyway.

Well, defined(SYMBOL) does not seem to be a valid C X-<, and I rewrote it in what I committed. But the point was that the whole thing:

	if (!FAST_WORKING_DIRECTORY && whatever)
		statement;

when FAST_WORKING_DIRECTORY is a compilation time constant, would be optimized out for sane platforms with a reasonable compiler.