Re: [PATCH] git-submodule: Make update verbose for up to date path
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2008, 20:31 UTC
- Message-ID
- <7v7igi5j08.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <46dff0320803040803v2f93d749t6b45fc8e47e66d21@mail.gmail.com>
"Ping Yin" <pkufranky@gmail.com> writes:
> When i run 'git submodule update' in a repository whose submodules are > all clean, there is not any output which makes me not know whether > this command are successful. I think this is not friendly.
Not at all. If you are unsuccessful and did not issue an error message, you have a bug to fix.
When a command finishes successfully doing what it was asked to do, especially when it does a lot of things and has potential to issue useful error messages and warnings to some but not all of them, it should stay quiet for successful ones unless there is a very good reason not to. The reasons may include "the user told it to be chatty with --verbose", "it may make the user think it hang, because it takes a long time", and perhaps "it is a rare thing to run and the user may not be familiar with how it acts".