Re: [PATCH 5/5] Introduce fast forward option only

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2008, 18:59 UTC
Message-ID: <7v7ielpxq5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <m3lk32p5z9.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 15 quoted lines

> "Sverre Hvammen Johansen" <hvammen@gmail.com> writes:
>
>> This feature is needed for git integration with accurev.
>> See the documentation for an explanation of this feature.
>
> I'd rather have description of the change in the commit message
> itself.  You can add "See the documentation for details", but the
> basic description, like:
>
>    This commit introcudes fast forward option 'only'.  With --ff=only
>    merge succeeds only if it resolves to fast-forward merge.
>  
> It would be nice to have described either in commit message, or in the
> documentation, _why_ it is needed for integration with AccuRev,
> i.e. what features of AccuRev or of integration requires this.

Including this message, I agree with what Jakub said as comments to this series. Readers of "git log" 6 months from now should not have to suffer "See Documentation", and reviewers of this series right now should not have to guess why it is a good idea and is worth reviewing by actually reading the patch.