Re: [PATCH v2] instaweb: make it compatible with Mac OS X 10.5's apache installation.

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2008, 18:42 UTC
Message-ID: <7v7idzz7no.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200805121952.55492.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 11 quoted lines

> Maybe you can use a function like this not tested one:
>
> check_cmd() {
> 	cmd="$1"
>
> 	if type "$cmd" > /dev/null 2>&1; then
> 		if "$cmd" -v | grep Apache > /dev/null 2>&1; then
> 			httpd=$(echo "$cmd" | sed "s/apache2/httpd/")
> 		fi
> 	fi
> }

One worry I have with that approach is if any and all random implementations of "httpd" that live somewhere in path do not do any harm when started with "-v" option. Namely, they should exit without becoming a daemon and/or start the service.

I am not convinced that would be the case.