git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] sort_in_topological_order(): avoid setting a commit flag

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 23, 2008, 01:01 UTC
Message-ID
<7v7ibdifbp.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0807230150480.8986@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> This is the same behavior as before, since indegree could not be
> non-zero when TOPOSORT was unset.
>
> Incidentally, this fixes the bug in show-branch where the 8th column
> was not shown: show-branch sorts the commits in topological order,
> assuming that all the commit flags are available for show-branch's
> private matters.

Do people still actively use show-branch as a G/CUI, especially after that "log --graph" thing was introduced?

If that is the case, it might also make sense to stop using the object flags but allocate necessary number of bits (not restricted to 25 or so) pointed at by commit->util field to remove its limitation.

Hint, hint...
Previous: Johannes SchindelinNext: Jon Loeliger
Message 3 of 8 in “Add test to show that show-branch misses out the 8th column”
  1. 1/2 Add test to show that show-branch misses out the 8th columnJohannes Schindelin, Jul 23, 2008
  2. 2/2 sort_in_topological_order(): avoid setting a commit flagJohannes Schindelin, Jul 23, 2008
  3. Junio C HamanoJul 23, 2008
  4. Jon LoeligerJul 23, 2008
  5. Petr BaudisJul 23, 2008
  6. Junio C HamanoJul 23, 2008
  7. Junio C HamanoJul 23, 2008
  8. Johannes SchindelinJul 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.