Re: [PATCH] rebase: do not fail silently when the HEAD could not be detached

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2009, 02:26 UTC
Message-ID: <7v7i414qb9.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090207233524.GD11623@atjola.homenet>

Björn Steinbrink <B.Steinbrink@gmx.de> writes:

Show 10 quoted lines

> On 2009.02.07 18:20:09 +0100, Johannes Schindelin wrote:
>> Since 6fd2f5e(rebase: operate on a detached HEAD), rebase operates on a
>> detached HEAD.  However, it used "checkout -q" to detach the HEAD, which
>> hid an error message when, say, an untracked file would have to be
>> overwritten to detach the HEAD.
>
> Hm, in 324c2c317 "git-rebase: report checkout failure", that was
> switched from a stdout/stderr redirect to -q, so that those error
> messages are shown. And with a quick test, rebase/checkout complains
> just fine:

Very interesting.

Dscho, how did you get the "important part of error information is hidden" failure that led to this patch? Did it come from code inspection and speculation alone, or was there an actual failure case?

If I apply the patch t/t3400-rebase.sh from your message alone to 'master', it does seem to pass.