git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2009, 15:50 UTC
Message-ID
<7v7hzufxcu.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20090602195533.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> writes:
Show 22 quoted lines
> Quoting Junio C Hamano <gitster@pobox.com>:
>
>> I actually like the rationale you mentioned in the thread (perhaps in the
>> original proposed commit message as well) that we should ask the freshly
>> built git to describe the version if available, falling back to whichever
>> git of random vintage found on the original $PATH.
>>
>> If it weren't for $X [*1*], my preference would have been (as I said in
>> the discussion) to run ./git if available locally.
>>
>> But I think your "deal with details like $X to figure out the name of the
>> freshly built git binary is in the Makefile, and pass it via GIT variable
>> to GIT-VERSION-GEN" is a sensible approach.  I do not remember if your
>> patch gave precedence to an installed git on the original $PATH or a
>> freshly built one, though---the precedent probably does not matter in
>> practice, and favoring the one found on $PATH over freshly built one does
>> have an advantage if we were to support cross compilation (I have a
>> suspicion that the current setup does not).
>>
>> Thanks.
>
> Junio, I think you forgot to take a follow-up action on this thread after sending this message.  The patch favors the git program in the current directory.

Indeed, I did, and I think I am Ok with the patch. Thanks for a reminder.

I thought there was an "simplicity" issue raised by J6t that was not addressed, but after re-reading the thread I do not think it applies (J6t?)

> Do you want to ask Matthias to resend the patch with an updated log message?

The proposed commit log message indeed does look somewhat incompatible with the normal style of our log messages, but I think I can rewrite it.

> P.S. a happy birthday ;-)

Heh, depending on where you are, you are a day or so late, but thanks anyway.

> -- 
> Nanako Shiraishi
> http://ivory.ap.teacup.com/nanako3/
Previous: Nanako ShiraishiNext: Johannes Sixt
Message 16 of 22 in “To make GIT-VERSION-FILE, search for git more widely”
  1. To make GIT-VERSION-FILE, search for git more widelyMatthias Andree, May 7, 2009
  2. Michael J GruberMay 7, 2009
  3. Matthias AndreeMay 7, 2009
  4. Michael J GruberMay 7, 2009
  5. Matthias AndreeMay 7, 2009
  6. Junio C HamanoMay 8, 2009
  7. Matthias AndreeMay 8, 2009
  8. Junio C HamanoMay 8, 2009
  9. Matthias AndreeMay 8, 2009
  10. Junio C HamanoMay 9, 2009
  11. Francis GaliegueMay 9, 2009
  12. Matthias AndreeMay 9, 2009
  13. Matthias AndreeMay 13, 2009
  14. Junio C HamanoMay 13, 2009
  15. Nanako ShiraishiJun 2, 2009
  16. Junio C HamanoJun 2, 2009
  17. Johannes SixtJun 2, 2009
  18. Matthias AndreeJun 3, 2009
  19. To make GIT-VERSION-FILE, search for git more widelyMatthias Andree, Jun 4, 2009
  20. Junio C HamanoJun 4, 2009
  21. Matthias AndreeJun 4, 2009
  22. Johannes SixtMay 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.