git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git format-patch from date never set

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 25, 2009, 23:03 UTC
Message-ID
<7v7hxwtlf7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com>
Dan Savilonis <djs@n-cube.org> writes:
Show 13 quoted lines
> On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen<raa.lkml@gmail.com> wrote:
>> Neither. This is not a date, but a part of "loosely defined" mbox format.
>>
>
> In the examples of mbox format I have found, the date in the From:
> line is generally the same as in the Date: line, albeit in a more
> ambiguous format. Further, the the git code treats it as a date and
> attempts to set it. It remains at the default date only because
> git_committer_info() is called without GIT_COMMITTER_DATE set.
>
> So is the code misleading? Was it designed to just meet the minimal
> requirement of having a date-like string to comform to the mbox
> format? What's the disadvantage to using the real commit date?

Having it as a fixed date-looking string was to help /etc/magic entry people may want to invent to detect format-patch output.

Previous: Dan SavilonisNext: Dan Savilonis
Message 4 of 5 in “git format-patch from date never set”
  1. Dan SavilonisJul 25, 2009
  2. Alex RiesenJul 25, 2009
  3. Dan SavilonisJul 25, 2009
  4. Junio C HamanoJul 25, 2009
  5. Dan SavilonisJul 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.