git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/7] Fix ignoring of pathspecs with rev-list --objects

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 26, 2010, 23:41 UTC
Message-ID
<7v7hjdkkm7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<AANLkTi=Y5tbdxc4f2j_1D1gib2gwEzNw6_Az3Ag9T1nn@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 19 quoted lines
> On Thu, Aug 26, 2010 at 9:50 AM, Elijah Newren <newren@gmail.com> wrote:
>>> While at it, can you please also fix its comments? The comments say
>>> pathspec while what it uses is actually path prefix...
>>> ...
>>> - * Is a tree entry interesting given the pathspec we have?
>>> + * Is a tree entry interesting given the path prefix we have?
>>
>> I believe the comment is parsed thus: "tree entry" == combination of
>> desc, base, and baselen... So I believe the original was
>> correct, though I can see how it's confusing at first.
>
> Pathspec as in match_pathspec() in dir.c allows wildcards...
>
> There is also a GSoC suggestion about this [1] and I posted a related
> patch a while back [2] but forgot it until now.
>
> [1] https://git.wiki.kernel.org/index.php/SoC2010Ideas#Unify_Pathspec_Semantics
>
> [2] http://mid.gmane.org/1243240924-5981-1-git-send-email-pclouds@gmail.com

As [1] you quoted says, both are called pathspecs and because our longer term goal is to unify them, I think the original comment is fine.

I wonder why I was Cc'ed on this shed-coloring committee, though...
Previous: Nguyen Thai Ngoc DuyNext: Elijah Newren
Message 8 of 16 in “Minor bug fix and optimizations for revision/tree walking”
  1. 0/7 Minor bug fix and optimizations for revision/tree walkingElijah Newren, Aug 25, 2010
  2. 1/7 Add testcase showing how pathspecs are ignored with rev-list --objectsElijah Newren, Aug 25, 2010
  3. 2/7 Fix ignoring of pathspecs with rev-list --objectsElijah Newren, Aug 25, 2010
  4. Nguyen Thai Ngoc DuyAug 25, 2010
  5. Elijah NewrenAug 25, 2010
  6. Elijah NewrenAug 26, 2010
  7. Nguyen Thai Ngoc DuyAug 26, 2010
  8. Junio C HamanoAug 26, 2010
  9. 3/7 tree-walk: Correct bitrotted comment about tree_entry()Elijah Newren, Aug 25, 2010
  10. 4/7 tree_entry_interesting(): Make return value more specificElijah Newren, Aug 25, 2010
  11. 5/7 diff_tree(): Skip skip_uninteresting() when all remaining paths interestingElijah Newren, Aug 25, 2010
  12. Junio C HamanoAug 25, 2010
  13. Elijah NewrenAug 25, 2010
  14. Junio C HamanoAug 26, 2010
  15. 6/7 list-objects.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 25, 2010
  16. 7/7 tree-diff.c: Avoid recomputing interesting-ness for subtrees when possibleElijah Newren, Aug 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.