Re: [PATCH] push: warn users about updating existing tags on push

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2010, 21:20 UTC
Message-ID: <7v7hj7er1h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.2.00.1008300924550.20874@narbuckle.genericorp.net>

Dave Olszewski <cxreg@pobox.com> writes:

Show 18 quoted lines

> On Mon, 30 Aug 2010, Junio C Hamano wrote:
>
> Thanks for the critique and comments
>
>> Dave Olszewski <cxreg@pobox.com> writes:
>> 
>> > Generally, tags are considered a write-once ref (or object), and updates
>> > to them are the exception to the rule.
>> 
>> This may be just the naming issue and you could say "moving them",
>> "updates to them" or "changing them" interchangeably in the above;
>> among them, "updates to them" sounds the most natural.
>> 
>> Can you change the "moving" in the patch to make them consistent with the
>> above description?
>
> Sure, no problem.  Would you like this changed in the variable and
> config names as well, or just the printed text?

The goal being making them consistent, the text and configuration variable (which are user-facing names) should match variables and functions (which are internal names). It would be inconsistent to store the value of the xfer.denyupdatetag configuration in deny_moving_tags variable, no?

I wondered if denyupdatetag should also forbid "git tag -f"; it would be awkward if we did so. The configuration is only about forbidding ref transfer operations from updating the tags.

But somehow core.denyupdatetag sounds as if "git tag -f" is also verboten and that is why I weatherballooned xfer.* in the first paragraph of this message.