git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] install-webdoc: quell diff output on stdout

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2010, 07:07 UTC
Message-ID
<7v7hizuz7h.fsf@alter.siamese.dyndns.org>
In-Reply-To
<52f347f82734e5d75d0b93a67edca9941efaa5a9.1283612149.git.git@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 5 quoted lines
> When installing html-doc, install-webdoc.sh compares the installed html
> with the version to be installed using diff. Currently, the diff output
> fills up stdout.
>
> install-webdoc.sh actually uses $DIFF, and is the only user.

I think you broke "tNNNN-X.sh -v"; isn't $DIFF used in t/ scripts everywhere?

Even if install-webdoc.sh were the sole user (which is not), please don't do it this way. Instead, introduce "SHOW_PATCH_WHILE_INSTALLING_WEBDOC" or something, and run "$DIFF" with "-q" when it is not set.

Otherwise you would forbid people from using $DIFF for its intended purpose: name a diff binary that can be used that is different from a crappy diff your platform gives you by default.

Previous: Michael J GruberNext: Michael J Gruber
Message 6 of 7 in “install-webdoc: quell diff output on stdout”
  1. install-webdoc: quell diff output on stdoutMichael J Gruber, Sep 1, 2010
  2. Junio C HamanoSep 1, 2010
  3. Michael J GruberSep 2, 2010
  4. Junio C HamanoSep 2, 2010
  5. [PATCHv2] install-webdoc: quell diff output on stdoutMichael J Gruber, Sep 6, 2010
  6. Junio C HamanoSep 6, 2010
  7. Michael J GruberSep 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.