Re: [PATCH] builtin/describe.c: ignore untracked changes in submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2010, 23:14 UTC
Message-ID: <7v7hipb5ht.fsf@alter.siamese.dyndns.org>
In-Reply-To: <150763691.8130046.1284401891268.JavaMail.fmail@mwmweb048>

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 9 quoted lines

>>>Perhaps the default setting of submodule.<name>.ignore should be 'untracked'?
>>
>>I still vote for none. I think the default should be to not have untracked files in
>>your projects (like you should not have warnings when compiling your project).
>>If that is not wanted, just use the configuration options git provides to change it.
>
> I forgot to mention: I think untracked files should mark a submodule as modified
> because otherwise it is too easy to forget adding new files inside submodules,
> as they won't show up when the 'ignore' setting is 'untracked' .

What makes untracked paths in the superproject different from the ones in a submodule? "git diff" cannot be it as it does not show untracked paths in the superproject, so you are talking about "the user cannot tell from the 'git status' output", right?

How about giving a new section in the status output that lists submodules with untracked paths, and do so only when ignore-submodules is set not to ignore them?