Re: [PATCH] send-email: Clear To: field for every mail

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2010, 07:09 UTC
Message-ID: <7v7hhya0yc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <a9b17bd454e57abb75f6cd2a7da63ec7738f5e7b.1286170305.git.viresh.kumar@st.com>

Viresh KUMAR <viresh.kumar@st.com> writes:

Show 7 quoted lines

> While sending multiple patches with a single git-send-email command,
> To: field is not cleared after every mail. This patch clears To: field
> after every patch sent.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> Tested-by: Viresh Kumar <viresh.kumar@st.com>
> ---

Heh, are people who send patches with only S-o-b by your definition not testing their patches at all ;-)? As far as I can tell, your patch applied to 'next' will break t9001 rather badly.

I agree there is a bug that you are trying to address in the series by Stephen that keeps adding To: address that is read from an earlier output of format-patch created with its --to option, but I do not think this is a right fix. Have you tested sending a series with a plain format-patch output without extraneous To:, Cc: and such headers?

A normal send-email session takes the recipient address from either --to or interactively upfront, and then use those addresses kept in @to variable in the loop, repeatedly. I do not see anything in your patch to avoid losing these addresses.