git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH for maint] git-completion: fix zsh support

From
Junio C Hamano <gitster@pobox.com>
Date
May 6, 2011, 04:51 UTC
Message-ID
<7v7ha44ej8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110505232503.GA7507@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
> Maybe simplest would be to use Szeder's fix + make the zsh version of
> _get_comp_words_by_ref not overwrite "words" at all?

I do not use zsh myself, but it appears to me that these three-patch series can graduate and if real zsh users find problems after using it they can be fixed independenty in-tree.

Would that risk too many patch ping-pong among zsh users on 'master'? The "don't declare 'local words' in zsh" patch seems to be the right work-around for the peculiar semantics of "words" array, at least to me.

Previous: Jonathan NiederNext: Jonathan Nieder
Message 7 of 14 in “git-completion: fix zsh support”
  1. git-completion: fix zsh supportFelipe Contreras, May 5, 2011
  2. Junio C HamanoMay 5, 2011
  3. Felipe ContrerasMay 5, 2011
  4. SZEDER GáborMay 5, 2011
  5. git-completion: fix zsh supportFelipe Contreras, May 5, 2011
  6. Jonathan NiederMay 5, 2011
  7. Junio C HamanoMay 6, 2011
  8. Jonathan NiederMay 6, 2011
  9. Felipe ContrerasMay 6, 2011
  10. Felipe ContrerasMay 6, 2011
  11. Jonathan NiederMay 6, 2011
  12. Jonathan NiederMay 6, 2011
  13. Felipe ContrerasMay 9, 2011
  14. Jonathan NiederMay 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.