Re: [PATCH v2 0/1] git-clone: fix relative path problem in the alternates

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2011, 19:10 UTC
Message-ID: <7v7h65w9d7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1314003957-9455-1-git-send-email-jason77.wang@gmail.com>

Hui Wang <jason77.wang@gmail.com> writes:

> 2. current git system only provides add_to_alternates_file()in the sha1_file.c
> to update lockfile, this function can add a line to lockfile but can't empty
> and write lockfile,

I do not see the need for "empty and write" in the first place. You are spending cycles to go through all the lines in the input, inspecting and holding the replacement somewhere, it is a one-time cost for cloning, and the alternates file wouldn't be humongous anyway, so I do not see the need for "we don't touch if there is no relative path in the file" if it makes the code more complex than a stupid "one line at a time" approach.

> 3. current existing add_to_alternates_file() will unconditionally append
> "/objects" at each new added line, that need us to parse and  remove
> "/objects" from each line read out from source alternates, this is a little
> bit complicated.

Clone with --reference is the only other caller of that function; I would say it is perfectly fine to make it the caller's responsibility to append "/objects" if that makes the resulting code easier to maintain.