git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] push -s: skeleton

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 8, 2011, 22:19 UTC
Message-ID
<7v7h5iwub9.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110908210217.GA32522@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Yeah, it is a potential problem, but it just seems wrong to put too much
> policy work onto the server.

My take on it is somewhat different. The only thing in the end result we want to see is that the pushed commits are annotated with GPG signatures in the notes tree, and there is no reason for us to cast in stone that there has to be any significance in the commit history of the notes tree.

In a busy hosting site that has many branches being pushed simultaneously, it is entirely plausible that the server side may just want to store each received push certificate in a new flat file in a filesystem, and have asynchronous process sweep the new certificates to update the notes tree, possibly creating a single notes tree commit that records updates by multiple pushes, for performance purposes, in its implementation of record_signed_push() in receive-pack.

If you forced the clients to also prepare notes and push the notes tree to the server, you are forcing the ordering in the history of the notes, and closing the door for such a server implementation. I would consider it an unnecessary and/or premature policy decision.

Previous: Jeff KingNext: Jeff King
Message 23 of 26 in “send-pack: typofix error message”
  1. 1/2 send-pack: typofix error messageJunio C Hamano, Sep 7, 2011
  2. 2/2 push -s: skeletonJunio C Hamano, Sep 7, 2011
  3. Shawn PearceSep 7, 2011
  4. Junio C HamanoSep 7, 2011
  5. Shawn PearceSep 7, 2011
  6. Junio C HamanoSep 8, 2011
  7. Nguyen Thai Ngoc DuySep 7, 2011
  8. Junio C HamanoSep 7, 2011
  9. Robin H. JohnsonSep 7, 2011
  10. Jeff KingSep 8, 2011
  11. Robin H. JohnsonSep 9, 2011
  12. Joey HessSep 9, 2011
  13. Drew NorthupSep 9, 2011
  14. Jeff KingSep 9, 2011
  15. 3/2 Split GPG interface into its own helper libraryJunio C Hamano, Sep 8, 2011
  16. 4/2 push -s: send signed push certificateJunio C Hamano, Sep 8, 2011
  17. 5/2 push -s: receiving endJunio C Hamano, Sep 8, 2011
  18. Johan HerlandSep 8, 2011
  19. Junio C HamanoSep 8, 2011
  20. Jeff KingSep 8, 2011
  21. Junio C HamanoSep 8, 2011
  22. Jeff KingSep 8, 2011
  23. Junio C HamanoSep 8, 2011
  24. Jeff KingSep 9, 2011
  25. Junio C HamanoSep 9, 2011
  26. Jeff KingSep 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.