git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] Improve use of select in http backend

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 3, 2011, 23:14 UTC
Message-ID
<7v7h3ger3t.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1320265288-12647-1-git-send-email-mika.fischer@zoopnet.de>

I re-read this thread once again, and my understanding of the current situation on these two patch series is the following. Please correct me if I am wrong.

 * This is not a regression fix, this is not a correctness fix, but it is
   a performance improvement;
 * Jeff gave an idea for improvement around the use of (rather, not having
   to use) data_received; and
 * Mika understood Jeff's suggestion, but was hesitant due to one
   potential issue around curl_multi_fdset() and asked Daniel's opinion,
   to which Daniel responded that the worrysome situation would not
   happen.

It appears to me that the next step is for Mika to decide either (1) we go ahead with the original patch and leave the improvement for later, or (2) update the patch as Jeff suggested and we review it again.

I can go either way, but whichever way you choose, I would want to see the patches properly signed-off.

Thanks.
Previous: Mika FischerNext: Mika Fischer
Message 9 of 19 in “[PATCHv2] Improve use of select in http backend”
  1. Mika FischerNov 2, 2011
  2. 1/2 http.c: Use curl_multi_fdset to select on curl fds instead of just sleepingMika Fischer, Nov 2, 2011
  3. Jeff KingNov 2, 2011
  4. Jeff KingNov 2, 2011
  5. Junio C HamanoNov 2, 2011
  6. Mika FischerNov 2, 2011
  7. Daniel StenbergNov 2, 2011
  8. 2/2 http.c: Use timeout suggested by curl instead of fixed 50ms timeoutMika Fischer, Nov 2, 2011
  9. Junio C HamanoNov 3, 2011
  10. 0/3 Improve use of select in http backendMika Fischer, Nov 4, 2011
  11. 1/3 http.c: Use curl_multi_fdset to select on curl fds instead of just sleepingMika Fischer, Nov 4, 2011
  12. 2/3 http.c: Use timeout suggested by curl instead of fixed 50ms timeoutMika Fischer, Nov 4, 2011
  13. Junio C HamanoNov 4, 2011
  14. Mika FischerNov 4, 2011
  15. Jeff KingNov 4, 2011
  16. Mika FischerNov 4, 2011
  17. Junio C HamanoNov 4, 2011
  18. 3/3 http.c: Rely on select instead of tracking whether data was receivedMika Fischer, Nov 4, 2011
  19. Jeff KingNov 4, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.